How to patch Duping and weapon slot glitch on your private server!

[KieronZeCoder69]

this is already patched on doomed realms (i think)
but if your server hasn't patched it yet your in for luck

Step 1.
Locate to /SOURCE\wServer\realm\entities\Player
and edit player.trade.cs with notepad++ (or whatever you use)

Step 2.
Ctrl + F
private void DoTrade()

Step 3.
replace everything under that with this

 

private void DoTrade()
{
string msg = "Trade Successful!";
string failmsg = "An error occured while trading!";
var thisItems = new List<Item>();
var targetItems = new List<Item>();

// make sure trade targets are valid
if (tradeTarget == null || Owner == null || tradeTarget.Owner == null || Owner != tradeTarget.Owner)
{
if (this != null)
psr.SendPacket(new TradeDonePacket
{
Result = 1,
Message = failmsg
});

if (tradeTarget != null)
tradeTarget.psr.SendPacket(new TradeDonePacket
{
Result = 1,
Message = failmsg
});

//TODO - logThis
return;
}

// get trade items
for (int i = 4; i < Inventory.Length; i++)
{
if (trade[i] && !Inventory[i].Soulbound)
{
thisItems.Add(Inventory[i]);
Inventory[i] = null;
UpdateCount++;

// save this trade info
if (itemnumber1 == 0)
{
items1 = items1 + " " + thisItems[itemnumber1].ObjectId;
}
else if (itemnumber1 > 0)
{
items1 = items1 + ", " + thisItems[itemnumber1].ObjectId;
}
itemnumber1++;
}


if (tradeTarget.trade[i] && !tradeTarget.Inventory[i].Soulbound)
{
targetItems.Add(tradeTarget.Inventory[i]);
tradeTarget.Inventory[i] = null;
tradeTarget.UpdateCount++;

// save target trade info
if (itemnumber2 == 0)
{
items2 = items2 + " " + targetItems[itemnumber2].ObjectId;
}
else if (itemnumber2 > 0)
{
items2 = items2 + ", " + targetItems[itemnumber2].ObjectId;
}
itemnumber2++;
}
}

// move thisItems -> tradeTarget
for (int j = thisItems.Count - 1; j >= 0; j--)
for (int i = 0; i < tradeTarget.Inventory.Length; i++)
{
if ((tradeTarget.SlotTypes[i] == 0 &&
tradeTarget.Inventory[i] == null) ||
(thisItems[j] != null &&
tradeTarget.SlotTypes[i] == thisItems[j].SlotType &&
tradeTarget.Inventory[i] == null))
{
tradeTarget.Inventory[i] = thisItems[j];
thisItems.RemoveAt(j);
break;
}
}

// move tradeItems -> this
for (int j = targetItems.Count - 1; j >= 0; j--)
for (int i = 0; i < Inventory.Length; i++)
{
if ((SlotTypes[i] == 0 &&
Inventory[i] == null) ||
(targetItems[j] != null &&
SlotTypes[i] == targetItems[j].SlotType &&
Inventory[i] == null))
{
Inventory[i] = targetItems[j];
targetItems.RemoveAt(j);
break;
}
}

// check for lingering items
if (thisItems.Count > 0 ||
targetItems.Count > 0)
{
msg = "An error occured while trading!";
}

// trade successful, notify and save
psr.SendPacket(new TradeDonePacket
{
Result = 1,
Message = msg
});
tradeTarget.psr.SendPacket(new TradeDonePacket
{
Result = 1,
Message = msg
});
SaveToCharacter();
psr.Save();
tradeTarget.SaveToCharacter();
tradeTarget.psr.Save();

// clean up
items1 = "";
items2 = "";
itemnumber1 = 0;
itemnumber2 = 0;
UpdateCount++;
tradeTarget.UpdateCount++;
tradeTarget.tradeTarget = null;
tradeTarget.trade = null;
tradeTarget.tradeAccepted = false;
tradeTarget = null;
trade = null;
tradeAccepted = false;
}
}
}

Step 4.
Scroll all the way back to the top
untill you see something like this:
bool[] trade;
bool tradeAccepted;

Step 5.
under bool tradeAccepted;
paste this in

 

private int itemnumber1;
private int itemnumber2;
public static string items1 { get; set; }
public static string items2 { get; set; }

it should now look like this


@Dragonlord3344 for doomed realm source
@me for being botherd to post this
@BlackRayquaza for annoying me on skype <3

edit
post any errors, i can help

[BlackRayquaza]

Ctrl + F

@C453 don't rage plez

[KieronZeCoder69]

@C453 don't rage plez

forgot credits for CTRL + F

[Stellar Spark]

For every patch to duping there are 5 other methods that can still dupe...

While I can't deny that this could be legitimately fixing the weapon slot glitch, the only way to patch duping is to redo the whole source, and even then there needs to be some checks to make sure it doesn't happen.

[KieronZeCoder69]

For every patch to duping there are 5 other methods that can still dupe...

While I can't deny that this could be legitimately fixing the weapon slot glitch, the only way to patch duping is to redo the whole source, and even then there needs to be some checks to make sure it doesn't happen.

yeah, no doubt there is duping methods.
but they are harder, so i am just releasing it so people won't dupe like crazy
considering this one is so easy to do

[sgrawsreghawrhgwrhgr]

This did indeed fix the slot glitch for me, nothing better to say then a thanks.

[KieronZeCoder69]

This did indeed fix the slot glitch for me, nothing better to say then a thanks.

your welcome

[Omniraptor]

This is good tutorial, thanks man.

[KieronZeCoder69]

This is good tutorial, thanks man.

no problem dude

[Mitcheel]

Great tut, thanks alot Kieron

[Dragonlord3344]

I hope to never see the item weapon glitch again.

[KieronZeCoder69]

I hope to never see the item weapon glitch again.

you won't now from this sweet ass tutorial

[filenub]

yeah, no doubt there is duping methods.
but they are harder, so i am just releasing it so people won't dupe like crazy
considering this one is so easy to do

Ironically you released a duping method that you could do on the MMOE source. I guess you had a change of heart.

[KieronZeCoder69]

Ironically you released a duping method that you could do on the MMOE source. I guess you had a change of heart.

yes <3 XD gotta release it then patch it