Trying to implement the 'FriendsList'

[sgrawsreghawrhgwrhgr]

This is how the XML data was structured on the project I mentioned above, it too used the X2 client, though I can't remember if we made any modifications to the friend lists:
getRequests : https://hastebin.com/bevadudoso.xml
getList : https://hastebin.com/oharatihok.xml


Looking at it now it's quite a lot, and I'm sure you could minimize it to just the essentials (Texture, Online, Name and what-not, I'm sure you don't need all the ClassStats etc.)

[FlashFlyyy]

This is how the XML data was structured on the project I mentioned above, it too used the X2 client, though I can't remember if we made any modifications to the friend lists:
getRequests : https://hastebin.com/bevadudoso.xml
getList : https://hastebin.com/oharatihok.xml


Looking at it now it's quite a lot, and I'm sure you could minimize it to just the essentials (Texture, Online, Name and what-not, I'm sure you don't need all the ClassStats etc.)

You do need the ClassStats I think.
Btw, I fixed up my XML structure but still not working. Keep getting a black faded screen when I click on 'Social' -_-

Also there is no request for '/friends/getRequests', so Idk

When I make '/friends/getList' return an error, client requests '/friends/getRequests' and this is the XML data. But still black faded screen -.-


This is my '/friends/getRequest' XML example data,

<Requests>
    <Account>
        <Character>
            <ObjectType>782</ObjectType>
            <Level>1</Level>
            <Exp>0</Exp>
            <CurrentFame>0</CurrentFame>
            <Texture>0</Texture>
        </Character>
        <Name>TestOne</Name>
        <Online>0</Online>
        <Stats>
            <ClassStats objectType="0x30e">
                <BestLevel>1</BestLevel>
                <BestFame>45</BestFame>
            </ClassStats>
            <BestCharFame>0</BestCharFame>
            <TotalFame>1045</TotalFame>
            <Fame>1045</Fame>
        </Stats>
    </Account>
</Requests>

This is my '/friends/getList' XML example data,

<Friends>
    <Account>
        <Character>
            <ObjectType>782</ObjectType>
            <Level>1</Level>
            <Exp>36</Exp>
            <CurrentFame>0</CurrentFame>
            <Texture>0</Texture>
        </Character>
        <Name>TestTwo</Name>
        <Online>0</Online>
        <Stats>
            <ClassStats objectType="0x30e">
                <BestLevel>1</BestLevel>
                <BestFame>45</BestFame>
            </ClassStats>
            <ClassStats objectType="0x31f">
                <BestLevel>9</BestLevel>
                <BestFame>3</BestFame>
            </ClassStats>
            <BestCharFame>3</BestCharFame>
            <TotalFame>1045</TotalFame>
            <Fame>45</Fame>
        </Stats>
    </Account>
</Friends>

EDIT
- tried 'objectType' as int instead of hex but doesn't change anything
- strange thing is, why was I able to see the box when it was giving errors? But when I give it data it doesn't work?
- btw, the commands such as 'Add Friend' work perfectly as I have used them using the tooltip box thing. So only problem is this thing :@
- btw,
If the XML data is correct then perhaps the issue might be this,

(...)
result += "</Requests>";
byte[] buf = Encoding.UTF8.GetBytes(result);
Context.Response.OutputStream.Write(buf, 0, buf.Length);
using (StreamWriter wtr = new StreamWriter(Context.Response.OutputStream))
wtr.Write("<Success/>");

Should I be writing something else?


OH ****************



I REMOVED THE HIGHLIGHTED PART AND IT WORKS NOW!!! OMFG :OOOOO

Btw,
What should "{amount}" be? So I can display the friend count?
https://i.gyazo.com/146b310145cfde89...f4f3513a39.mp4

[sgrawsreghawrhgwrhgr]

Try simply exporting <Friends></Friends> & <Requests></Requests>. If those don't work (still black screen), then you're doing something wrong, I unfortunately do not remember exactly how the whole friend-list mechanic works, but the things I put above should 100% work, you must be able to open the UI by exporting them, and if the UI does not open, you're most likely not handling your requests correctly (perhaps you mixed them up somewhere, just have a recheck)

[FlashFlyyy]

Try simply exporting <Friends></Friends> & <Requests></Requests>. If those don't work (still black screen), then you're doing something wrong, I unfortunately do not remember exactly how the whole friend-list mechanic works, but the things I put above should 100% work, you must be able to open the UI by exporting them, and if the UI does not open, you're most likely not handling your requests correctly (perhaps you mixed them up somewhere, just have a recheck)

It's fine it works!
Btw,

1. What should "{amount}" be? So I can display the friend count?
https://gyazo.com/146b310145cfde89205262f4f3513a39

2. Does the 'Search' functionality not work as it is not implemented?

    public static const SEARCH:String = "searchFriend";

Should this in the client be:

    public static const SEARCH:String = "/searchFriend";

Then make another handler for it?

3. When a player has no friends they can't open their friends list. What XML should I pass when there's no data? I thought of,

<Friends>
</Friends>

But this doesn't work.

[sgrawsreghawrhgwrhgr]

1) Look into the client to see how it handles the {amount} stuff, but I think you're using the new production language strings that have different stuff
Take a look here: https://hastebin.com/abukizihen.json
Those are the strings that we used, and everything looked okay, don't just copy & paste it as I believe it has some differences (as it was a custom server project), just look over the friends stuff
2) I don't think it is implemented, you'd have to debug that a little, try logging if a request/unknown packet is sent to server
3) That should work fine, check over your code

[FlashFlyyy]

3) That should work fine, check over your code

Well...it doesn't

[sgrawsreghawrhgwrhgr]

Well...it doesn't

Export <Requests></Requests> for /getRequests, <Friends></Friends> for /getList

[FlashFlyyy]

Export <Requests></Requests> for /getRequests, <Friends></Friends> for /getList

That's what the screenshot is showing lol



NVM!! lol I found the problem

It was this else statement,

                    //else
                    //{
                    //    using (StreamWriter wtr = new StreamWriter(Context.Response.OutputStream))
                    //        wtr.Write("<Error>Not a pending friend request</Error>");
                    //}

[sgrawsreghawrhgwrhgr]

Yeah my bad, I was thinking you exported <Friends></Friends>, didn't see the other CMD.
Either way, I was wrong.
Export <Friends/> & <Requests/> if you don't have anything else to export, that should be good (that's what we did at least, other option should work the same)

[FlashFlyyy]

Yeah my bad, I was thinking you exported <Friends></Friends>, didn't see the other CMD.
Either way, I was wrong.
Export <Friends/> & <Requests/> if you don't have anything else to export, that should be good (that's what we did at least, other option should work the same)

OH!! 'Search' doesn't search for players in database to add. It just filters your friendlist... lol

Export <Friends/> & <Requests/> if you don't have anything else to export, that should be good (that's what we did at least, other option should work the same)

I will take note of this, thanks!

- - - Updated - - -

Any idea how to fix the 'server name' description?

[sebastianfra12]

OH!! 'Search' doesn't search for players in database to add. It just filters your friendlist... lol



I will take note of this, thanks!

- - - Updated - - -

Any idea how to fix the 'server name' description?

Change "<Online>value</Online>" to your server's ip

[FlashFlyyy]

Change "<Online>value</Online>" to your server's ip

Is there a simple way to obtain the IP address of the connected server? Other than using 'Dns'?

Also, if the player is offline what should value be?

EDIT: If player is offline there will be no '<Online>' tag

[DevilRotMG]

I'm assuming you only have 1 server, so the IP would just be the ip of the server in server.cfg

[FlashFlyyy]

I'm assuming you only have 1 server, so the IP would just be the ip of the server in server.cfg

Ye, but if say in the future I have more I want to dynamically assign it

[SeXZeFPS]

This is how NR-Core get's the users

var servers = player.Manager.InterServer.GetServerList();

            foreach (var server in servers)
                foreach (PlayerInfo plr in server.playerList)
                {
                    if (!plr.Name.Equals(name, StringComparison.InvariantCultureIgnoreCase) ||
                        plr.Hidden && !player.Client.Account.Admin)
                        continue;

                    player.SendInfo($"{plr.Name} is playing on {server.name} at [{plr.WorldInstance}]{plr.WorldName}.");
                    return true;
                }