[HELP]Drawing a crosshair

[♪~ ᕕ(ᐛ)ᕗ]

Well after followed the HD's tut I found the pointer to the CreateDevice. But it won't draw my corsshair.

This is what I do:

void (*oEndScene)(void);

void DrawCrosshair(IDirect3DDevice9 *pDevice)
{
	D3DRECT pRect1;
	int x1 = ((GetSystemMetrics( 0 )) / 2) - 35;
	int x2 = ((GetSystemMetrics( 0 )) / 2) + 35;
	int y1 = ((GetSystemMetrics( 1 )) / 2) - 5;
	int y2 = ((GetSystemMetrics( 1 )) / 2) + 5;
	pRect1.x1 = x1;
	pRect1.x2 = x2;
	pRect1.y1 = y1;
	pRect1.y2 = y2;
	pDevice->Clear(0, &pRect1, 0, (D3DCOLOR_XRGB(255, 0, 0)), 0, 0);
	D3DRECT pRect2;
	int aX = ((GetSystemMetrics( 0 )) / 2) - 5;
	int aX2 = ((GetSystemMetrics( 0 )) / 2) + 5;
	int aY = ((GetSystemMetrics( 1 )) / 2) - 35;
	int aY2 = ((GetSystemMetrics( 1 ) / 2)) + 35;
	pDevice->Clear(0, &pRect2, 0, (D3DCOLOR_XRGB(255, 0, 0)), 0, 0);
}

void xEndScene(void)
{
       	oEndScene();

	IDirect3DDevice9 *pDevice = *(IDirect3DDevice9**)0x6737268;

	DrawCrosshair(pDevice);
}

Now this is the thread that I add in the process (iw4mp.dat):

void ShakeBaby(void)
{
	oEndScene = (void (__cdecl *)(void))DetourFunction((PBYTE)0x586E00, (PBYTE)xEndScene);
	while(1) Sleep(10);
}

Please help me, the game doesn't crash but it simply won't draw my crosshair.

[radnomguywfq3]

What's oEndScene? If that finalizes the rendering, you should call it _after_ you render your crosshair, because the game, should in theory, be about to finalize the rendering when calling xEndScene, and so it would make sense to draw there and then finalize.

Also, you shouldn't be clearing the screen if you're rendering over an existing frame.

AFAIK, you don't seem to be initilizing pRect2 either.

Why don't you just initilize a basic vertex buffer and draw a line-list on the near-plane? I see what you're trying to do with the clear member function of the device but it's a bit of an odd route to take.

[♪~ ᕕ(ᐛ)ᕗ]

Gonna try.....

[freedompeace]

void ShakeBaby(void)
{
	oEndScene = (void (__cdecl *)(void))DetourFunction((PBYTE)0x586E00, (PBYTE)xEndScene);
	while(1) Sleep(10);
}

That just means you set oEndScene, and suspend the thread forever...

You aren't actually drawing anything at all.

Logic please.

[radnomguywfq3]

void ShakeBaby(void)
{
    oEndScene = (void (__cdecl *)(void))DetourFunction((PBYTE)0x586E00, (PBYTE)xEndScene);
    while(1) Sleep(10);
}

That just means you set oEndScene, and suspend the thread forever...

You aren't actually drawing anything at all.

Logic please.

It depends on what calls ShakeBaby(). I assume he created a thread, and, for some reason, wants to keep it alive (probably not a good one though.) If he hooks the render routine it will be called by the targets thread and so his thread doesn't even need to continue after execution.

Btw you need to call DetourCommit after DetourTransactionBegin();

DetourTransactionBegin();
Detour the functions here
DetourTransactionCommit();

If you have a handle to the executing thread, you should also call
DetourUpdateThread before commiting.

SO if you want to use the clear screen method, you can use that. I bet that's the reason your cross hair wasn't rendering.

[freedompeace]

My bad . <<

[Hell_Demon]

which would logically lead to the result of his crosshair not being drawn.

If he successfully detours it will still draw since it's a seperate thread from the one he suspended

[♪~ ᕕ(ᐛ)ᕗ]

Well everything that I draw using the game engine, appears while in game. Anyways...
@Jetamay
Those Detour function can't be found at my detorus.h.

EDIT:
LOL! I forgot to init. the pRect2.

Now I realized it. Feel so much asleep. -_-

[Hell_Demon]

MS Detours 1.5 doesn't have DetourTransactionBegin and Commit, so you're fine =P

[♪~ ᕕ(ᐛ)ᕗ]

MS Detours 1.5 doesn't have DetourTransactionBegin and Commit, so you're fine =P

I really have 1.5? :O

[Hell_Demon]

Most likely

[♪~ ᕕ(ᐛ)ᕗ]

Most likely

I feel kinda embarrassed.

EDIT:
Aww I installed 2.1 since 3.00 is not free. But I simply can't find em.

[whit]

I feel kinda embarrassed.

EDIT:
Aww I installed 2.1 since 3.00 is not free. But I simply can't find em.

Google Detours express 1.5 and you will see them posted on UC ...

[♪~ ᕕ(ᐛ)ᕗ]

Google Detours express 1.5 and you will see them posted on UC ...

I need an updated version. Not 1.5.

EDIT:
Well it' now fixed. But it says that DetourFunction is undefined. -.-
I tried to put it on the detours.h, but it still won't work.

[aanthonyz]

What about the library file for Detours?