Disable Client Swap

[nilly]

This is just a small fix for those of you who are getting bugged loot. It fixes the problem of having phantom loot in your inventory (i.e. client shows you picked up loot then, after nexusing, the loot is no longer in your inventory).

4.0.0_autoloot_disClientSwap.txt

jump L163 ;L164 points to the label just before the sound call at the end of the function.

4.0.0_disClientSwap.xml

<?xml version="1.0" encoding="UTF-8"?>

<rotmg>
    <mod id="Disable Client Swap">
        <code file2mod="com/company/assembleegameclient/net/_-KA.class.asasm"
              line="2932">
            4.0.0_autoloot_disClientSwap.txt
        </code>
    </mod>
</rotmg>

If you haven't already guessed, this was made for the 4.0.0 mod selector as a part of the new auto-looter I made. Just save the text in each code section in a file named the same as the corresponding bold text above that section.

[Madmayhem]

Wow, this sounds great....
How exactly does this work?

[nilly]

Well when you move loot around, a function is called that preps the INVSWAP packet. In this function, after the INVSWAP packet is sent off, it manually switches the loot on the client side even before the server can confirm the swap. The problem is, if the loot fails to swap for whatever reason the client doesn't register this failure. It continues to display the loot as it was when the INVSWAP packet was sent off. What this does is disables that client side switch. If the loot swap was successful it will register on the client, if not then it will stay where it originally was.

[BernardoLima]

Well when you move loot around, a function is called that preps the INVSWAP packet. In this function, after the INVSWAP packet is sent off, it manually switches the loot on the client side even before the server can confirm the swap. The problem is, if the loot fails to swap for whatever reason the client doesn't register this failure. It continues to display the loot as it was when the INVSWAP packet was sent off. What this does is disables that client side switch. If the loot swap was successful it will register on the client, if not then it will stay where it originally was.

Do you know that because of the debugger?

[nilly]

You don't really need a debugger to figure this out but yes I used one. I found this out when testing the auto-loot mod I made. If I looted too fast I would get lots of phantom items. Looking at the code, it clearly shows that it is manually swapping the items before the server even swaps the items.

[UltraN00b]

@nilly Too bad that the devs are too lazy to correct this... Great job!

---------- Post added at 01:17 AM ---------- Previous post was at 01:16 AM ----------

Also Parameters could be a good class to start renaming variables.

[JustAnoobROTMG]

Nice find!

If hackers are starting to correct WildShadow bugs, this is the beginning of the end .....

[gorgor]

One simple question....
do this swap is the responsible for not letting us dupe ?

[nilly]

I'm not sure what role the swap has with duping, if any. One interesting observation, If the client manually swaps loot, the server's response doesn't change the swap if it fails. However if the client doesn't manually swap, for some reason the response from the server updates where the loot should be. I'm not sure why the update from the server doesn't reset the client side swap when moving loot fails.

[gorgor]

I read that the solution to the duping was to swap all inventory once before nexusing...

[nilly]

The solution to duping? As in the solution to fixing duping or the solution to allow duping? It couldn't be the former since items actually do swap before nexusing and it couldn't be the latter because you can't swap more than one item at once (unless you are talking about duping one item at a time). In any case, it sounds like the person who said that doesn't know what they are talking about.

[zackdove]

Does this work for 5.0?

[nilly]

Naw. This is for the old version. I'll need to updated it for 5.0. Forgot about it.

---------- Post added at 02:13 PM ---------- Previous post was at 02:03 PM ----------

@Nachos, @Temperrr please mark thread as outdated.

---------- Post added at 02:29 PM ---------- Previous post was at 02:13 PM ----------

@zackdove, this has been updated for the 5.0 mod selector. You can find it in the op of that thread. Thanks for reminding me.

[pendal331]

Thanks nilly, going to +1

[nilly]

@Nachos, @Temperrr please mark thread as outdated.