Crashing... Help?

[cubanelite]

Weird as shit but it works.

Edit: The bDataCompare function is detected.
I had to comment it out because it was getting my base detected after 5 mins.

The bDataCompare function is most certainly Not detected. I played a few games of qr earlier with it fine?

You can easily condense this algorithm to:

if (Hack && InGame())
          memcpy(address, PatchBytes, Size);
      else
          memcpy(address, OriginalBytes , Size);

Or, why not try some ternary operators

(Hack && InGame())?memcpy(address, PatchBytes, Size):memcpy(address, OriginalBytes , Size);

The code written by the OP of this thread made me want to cry it was so inefficient. Function calls are pretty expensive, and he made TONS of unnecessary ones. At the beginning of each frame, cache the result of the InGame call to a variable, and then use that.

//gobals
bool statusCache;

//top of present

statusCache = InGame();

//then for accessing it
if (Hack && statusCache)
          memcpy(address, PatchBytes, Size);
      else
          memcpy(address, OriginalBytes , Size);

This would save lots of resource usage over time.

I'm no good at making my code really clean. I've been working on making my coding cleaner, and more efficient for my next release. Thank you for the help! It means alot.

[kibbles18]

if you want efficent code use asm
clean code is not the same as efficient code

[cubanelite]

if you want efficent code use asm
clean code is not the same as efficient code

asm isn't one of my strongest languages... and, I said, and I quote: "making my coding cleaner, and more efficient"

[Saltine]

if you want efficent code use asm
clean code is not the same as efficient code

asm is only efficient in the right hands. Someone who doesn't know what they are doing will often write an algorithm slower than one that they would have written in native C. And yes, clean != efficient. One example is packing all of your code into one main method. It looks horrible, but in the end, it saves resources due to reducing function calls.

[Jason]

Or, why not try some ternary operators

(Hack && InGame())?memcpy(address, PatchBytes, Size):memcpy(address, OriginalBytes , Size);

Why make things more difficult to read? Either way you're calling memcpy:

memcpy(address, (Hack && InGame() ? PatchBytes : OriginalBytes), Size);

And Proper-Cased variables names? Yuk.