[FSOD] Need help with code...

[FSOD] Need help with code... - MPGH

Originally Posted by LordChronos

I tried to add my own 'task system' as in realm resolution source and I wrote some code where if you have the required item, it give you the reward and replaces the 'task tablet' with the next 'task tablet'.
Code:-
case ActivateEffects.Task1:
{
// try
//{
for (int i = 0; i < Inventory.Length; i++)
if (Inventory[i].ObjectId == "Dragon Pearl")
{
{
if (Inventory[i] == null) continue;
if (Inventory[i].ObjectId == "Dragon Pearl") ;
//if (Inventory[4] != null) { return false; }
//if (Inventory[5] != null) { return false; }
{
Inventory[i] = Manager.GameData.Items[0x108e];
//Inventory[5] = Manager.GameData.Items[0x42c9];
UpdateCount++;
SaveToCharacter();
SendInfo("You have completed the task!");
return true;
};
if (Inventory[i].ObjectId == "Task Tablet 1")
{
Inventory[i] = Manager.GameData.Items[0x42c9];
UpdateCount++;
SaveToCharacter();
return true;
}
}
};
//}
//catch
//{
// {
// SendHelp("You have to have your first 2 slots empty!");
// }
//return false;
//}
};
break;
What's the problem with this? Every time I use it, the reward works but the task tablet doesn't change.
P.S How to put this in 'code' thing again :P ?
Thanks in Advance!

Can you reenter the code in a [CODE] // [/ CODE] format and can you explain what your trying to do and what is happening better... cause its way too hard for me too read the code and problem, too unorganized

Originally Posted by LordChronos

Code:

case ActivateEffects.Task1:
                        {
                            for (int i = 0; i < Inventory.Length; i++)
                                if (Inventory[i].ObjectId == "Dragon Pearl")
                                {
                                    {
                                        if (Inventory[i] == null) continue;
                                        if (Inventory[i].ObjectId == "Dragon Pearl") ;true; }
                                        {
                                            Inventory[i] = Manager.GameData.Items[0x108e];
                                            UpdateCount++;
                                            SaveToCharacter();
                                            SendInfo("You have completed the task!");
                                            return true;
                                        };
                                        if (Inventory[i].ObjectId == "Task Tablet 1")
                                        {
                                            Inventory[i] = Manager.GameData.Items[0x42c9];
                                            UpdateCount++;
                                            SaveToCharacter();
                                            return true;
                                        }
                                    }
                                };
                        };
                        break;

What's the problem with this? Every time I use it, the reward works but the task tablet doesn't change.
P.S How to put this in 'code' thing again :P ?
Thanks in Advance!

First of all your code is extremely dirty and hard to read.
Reading your thread I still can't understand what your trying to do. If you could, please explain it better.

How exactly is your task system supposed to function? And what is it doing?

Normally I would rewrite your code for you, but i'm at school and can't be bothered to do so until I get more details.

Code:

                    case ActivateEffects.XmasTablet2:
                        {
                            int LockboxChance = Random.Next(0, 1);
                            Random rand = new Random();
                            string taskname = "";
                            switch (LockboxChance)

                            {
                                case 0:
                                    for (int i = 0; i < Inventory.Length; i++)
                                    {
                                        if (Inventory[i] == null) continue;
                                        if (Inventory[i].ObjectId == "Xmas Santa Hat")
                                        {
                                            Inventory[i] = Manager.GameData.Items[0x441a];
                                            UpdateCount++;
                                            SaveToCharacter();
                                            SendHelp("Next task unlocked!");
                                            TextPacket packet = new TextPacket
                                            {
                                                BubbleTime = 0,
                                                Stars = -1,
                                            };
                                            return false;
                                        }
                                    };
                                    break;
                            }
                            if (taskname == "")
                            {
                                SendHelp("You do not have to correct materials to activate a task.");
                            }
                            else
                            {
                                TextPacket packet = new TextPacket
                                {
                                    BubbleTime = 0,
                                    Stars = -1,
                                    Name = "",
                                    Text = Name + " has activated the task [" + taskname + "]"
                                };
                                Owner.BroadcastPacket(packet, null);
                                SendHelp("Xmas task has been activated!");
                            }
                            return true;
                        }
                        break;

This is what I use for a task system. Is sorta messy but it works. 0x441a in this is the next tablet and it's given if you have "xmas santa hat"

Originally Posted by swankhawk

Code:

                    case ActivateEffects.XmasTablet2:
                        {
                            int LockboxChance = Random.Next(0, 1);
                            Random rand = new Random();
                            string taskname = "";
                            switch (LockboxChance)

                            {
                                case 0:
                                    for (int i = 0; i < Inventory.Length; i++)
                                    {
                                        if (Inventory[i] == null) continue;
                                        if (Inventory[i].ObjectId == "Xmas Santa Hat")
                                        {
                                            Inventory[i] = Manager.GameData.Items[0x441a];
                                            UpdateCount++;
                                            SaveToCharacter();
                                            SendHelp("Next task unlocked!");
                                            TextPacket packet = new TextPacket
                                            {
                                                BubbleTime = 0,
                                                Stars = -1,
                                            };
                                            return false;
                                        }
                                    };
                                    break;
                            }
                            if (taskname == "")
                            {
                                SendHelp("You do not have to correct materials to activate a task.");
                            }
                            else
                            {
                                TextPacket packet = new TextPacket
                                {
                                    BubbleTime = 0,
                                    Stars = -1,
                                    Name = "",
                                    Text = Name + " has activated the task [" + taskname + "]"
                                };
                                Owner.BroadcastPacket(packet, null);
                                SendHelp("Xmas task has been activated!");
                            }
                            return true;
                        }
                        break;

This is what I use for a task system. Is sorta messy but it works. 0x441a in this is the next tablet and it's given if you have "xmas santa hat"

@swankhawk Wait, this seems a bit too complicated and does it need any changes in the database?

- - - Updated - - -

Originally Posted by DemonLives

Let me ask you a question. Is task tablet 1 consumed?

but heres a more organized code

Code:

         for (var i = 0; i < Inventory.Length; i++)
            {
               if (Inventory[i].ObjectId == "Dragon Pearl")
               {
                   Inventory[i] = Manager.GameData.Items[0x108e];
                   Player.SendInfo("Quest Complete");
                   UpdateCount++;
                   SaveToCharacter();
               }
               if(Inventory[i].ObjectId == "Task Tablet 1")
               {
                   Inventory[i] = Manager.GameData.Items[0x42c9];
                   UpdateCount++;
                   SaveToCharacter();  
               }
            }

didn't test it or anything so might not even be functional

@DemonLives Here if where the problem lied, you see I wanted the task tablet 1 to change to task tablet 2 only if the character had the item to complete the task.
With your code, if the person uses the tablet without having the item, it just directly switches over to the next task....

And when I tried to fix this problem myself, the code had the "unreachable code detected" error.

[FSOD] Need help with code...

Post a Reply

Similar Threads

Tags for this Thread