Reason for ban [more towards staff]

[hackinet4]

i always thought vb rebuilt everything every major update, or atleast change A LOT of the inner-workings. i could be wrong. (they sell each vb major version separated, or atleast they used to)

and you'll probably get some php compatibility issues.

No they don't update the core code, they just keep adding new features. There was only 1 major update from v3.x to v4.x, and it was the template part. I don't think it(but maybe? who knows ) would be a PHP compatibility issue as the hooks and objects haven't been touched. Here are the version logs: https://en.wikipedia.org/wiki/VBulletin#vBulletin_4 (can't link to the official release notes as they require you to be a paid customer)

[Silent]

No they don't update the core code, they just keep adding new features. There was only 1 major update from v3.x to v4.x, and it was the template part. I don't think it(but maybe? who know ) would be a PHP compatibility issue as the hooks and objects haven't been touched. Here are the version logs: https://en.wikipedia.org/wiki/VBulletin#vBulletin_4 (can't link to the official release notes as they require you to be a paid customer)

I'm not that familiar with vB. As for the PHP compatibility thing I mentioned, I thought PHP changed the class constructors in 5.4.

[hackinet4]

I'm not that familiar with vB. As for the PHP compatibility thing I mentioned, I thought PHP changed the class constructors in 5.4.

Me neither.
And Unless the vB is using PHP v7.x there shoudn't be a problem with compatibility issues relating to that of constructors because

and on the other hand this vB plugin doesn't use constructors.

[Silent]

Me neither.
And Unless the vB is using PHP v7.x there shoudn't be a problem with compatibility issues relating to that of constructors because

and on the other hand this vB plugin doesn't use constructors.

yah ik about the php 7 constructor update, but I thought there was a much littler update to the constructors around 5.4, must be misremembering xd

php is a mess.

[hackinet4]

yah ik about the php 7 constructor update, but I thought there was a much littler update to the constructors around 5.4, must be misremembering xd

php is a mess.

No you are absolutely right. The new unified constructor

void __construct ([ mixed $args [, $... ]] )

was implemented in PHP5 as you said above. What I meant is that this new method is necessary for PHP7.

[thoughtful]

I think it should be way more easier to view why a user is banned and this is a possible way:
when you hover over someones "BANNED" it should have a little statement or a sentence of why ban was placed.

I honestly think that it should be easily accessible instead of us having to investigate & look through the ban requests.

Should this be a thing? why isn't it a thing?

I agree with this 100%

[BabyCrazy]

Bump.

@Dave84311 @arunforce

[[MPGH]Dave84311]

vbulletin 3 plugins are NOT compatible with vbulletin 4 plugins

[BabyCrazy]

@Dave84311

Couldn’t it Have a “banned: Scam” above image title.

[Silent]

@ @Dave84311

Hook location: fetch_musername

if ($user['usergroupid'] == /* Banned Usergroup... Hardcoding... */ 8) {
	if(isset($GLOBAL['TITLE-CACHE'][$user['userid']])) {
		$user['usertitle'] = $GLOBAL['TITLE-CACHE'][$user['userid']];
	}
	else {
		$query = "
		SELECT
			(
				SELECT `username`
				FROM ".TABLE_PREFIX."user
				WHERE userid = ub_table.adminid
				LIMIT 1
			) AS username,
			ub_table.bandate,
			ub_table.liftdate,
			ub_table.reason
		FROM ".TABLE_PREFIX."userban AS ub_table
		WHERE
			ub_table.userid = " . intval($user['userid']) ."
		ORDER BY ub_table.bandate DESC
		LIMIT 1";
		
		$result = $vbulletin->db->query_first_slave($query);
		
		
		if($result !== false) {
			$user['usertitle'] = "Banned by <u>".htmlentities($result['username'])."</u>";
			$user['usertitle'] .= "<br />For <u>".htmlentities($result['reason'])."</u>";
			
			if($result['liftdate'] > 0) {
				$user['usertitle'] .= "<br />Set to expire <u>".vbdate($vbulletin->options['dateformat'] . ', ' . $vbulletin->options['timeformat'], $result['liftdate'])."</u>";
			}
			
			$GLOBAL['TITLE-CACHE'][$user['userid']] = $user['usertitle'];
		}
	}
}

tested in vb 4.2.5 (didn't want to reconfigure apache to test)

duration bans:


perma bans:


could be (a lot) more efficient, but i cba. it only took like 5 minutes to make plus the time it took to install vb.

edit: the hook caller can be found in functions.php @ method fetch_musername (ss of method this hook is called from https://s.msger.us/i/3c9a1e22jLRp.png )

[BabyCrazy]

@Dave84311 update?

[Silent]

@Dave84311 update?

if he implements mine, he will have to add a simple filter for account purges and a few other things. I'd be happy to update it to make it more suited for this forum, but I'm not going to spend time on it if it's not going to be used.

edit: I got no life...

if ($user['usergroupid'] == /* Banned Usergroup... Hardcoding... */ 8) {
	if(isset($GLOBAL['TITLE-CACHE'][$user['userid']])) {
		$user['usertitle'] = $GLOBAL['TITLE-CACHE'][$user['userid']];
	}
	else {
		$query = "
		SELECT
			(
				SELECT `username`
				FROM ".TABLE_PREFIX."user
				WHERE userid = ub_table.adminid
				LIMIT 1
			) AS username,
			ub_table.adminid,
			ub_table.bandate,
			ub_table.liftdate,
			ub_table.reason
		FROM ".TABLE_PREFIX."userban AS ub_table
		WHERE
			ub_table.userid = ". intval($user['userid']) ."
		ORDER BY ub_table.bandate DESC
		LIMIT 1";
		
		$result = $vbulletin->db->query_first_slave($query);
		
		
		if($result !== false) {
			$user['usertitle'] = "Banned by <a href=\"member.php?u={$result[adminid]}\">". htmlentities($result['username']) ."</a>";
			
			
			// Add custom censor here...
			$censored = (strpos($result['reason'], "Account purge requested") !== false);
			
			
			if(!$censored) {
				$user['usertitle'] .= "<br />For <u>". htmlentities($result['reason']) ."</u>";
			}
			
			
			if($result['liftdate'] > 0) {
				$user['usertitle'] .= "<br />Set to expire <u>". vbdate($vbulletin->options['dateformat'] . ', ' . $vbulletin->options['timeformat'], $result['liftdate']) ."</u>";
			}
			
			
			$GLOBAL['TITLE-CACHE'][$user['userid']] = $user['usertitle'];
		}
	}
}

With censor:


Without:


And the duration is still the same.

[Destiny]

If it will come it could be very useful

[coolchad]

Good idea.

[BabyCrazy]

@Dave84311

update??