Int++ increases by 10 or more C++

[wara286]

Hello,
I got a problem:
I am currently writing a dll for COD MW3 and I'm trying to do a wallhack.
For that i need the correct stride number and to find that out I increase an int every time I type the NUM1 key on my keyboard.
The current int is displayed on the screen.
My problem is that the number displayed on the screen increases by one the first time I type NUM1, but the second time it increases by 10 and then by one agin, the third time it increases by 89 so I am at 100.
I think that the problem could be
A: here:

	
if (GetAsyncKeyState(VK_NUMPAD0)&1) 
{ 
	strideNum +=1;
}

or B: here:

        char buffer[20];
	_itoa_s(strideNum,buffer,20,2);
	LPCSTR p = buffer;
	Draw_Text(p, 200, 5, txtGreen, HeaderFont);

Maybe it could have something to do with the conversion of the int to a LPCSTR that can be drawn on the screen.

I hope that there will be some good answers soon

EDIT:
Maybe I should mention that if I decrease the number it decreases in exactly the same steps that it increased before.

[somewhatpro]

Hello,
I got a problem:
I am currently writing a dll for COD MW3 and I'm trying to do a wallhack.
For that i need the correct stride number and to find that out I increase an int every time I type the NUM1 key on my keyboard.
The current int is displayed on the screen.
My problem is that the number displayed on the screen increases by one the first time I type NUM1, but the second time it increases by 10 and then by one agin, the third time it increases by 89 so I am at 100.
I think that the problem could be
A: here:

	
if (GetAsyncKeyState(VK_NUMPAD0)&1) 
{ 
	strideNum +=1;
}

or B: here:

        char buffer[20];
	_itoa_s(strideNum,buffer,20,2);
	LPCSTR p = buffer;
	Draw_Text(p, 200, 5, txtGreen, HeaderFont);

Maybe it could have something to do with the conversion of the int to a LPCSTR that can be drawn on the screen.

I hope that there will be some good answers soon

EDIT:
Maybe I should mention that if I decrease the number it decreases in exactly the same steps that it increased before.

add a little sleep to slow it down.

if (GetAsyncKeyState(VK_NUMPAD0)&1) 
{ 
	strideNum++;
        Sleep(100);
}

btw it's better to use sprintf :

char buffer[32];
sprintf(buffer, "strideNum : %d", strideNum);

[abuckau907]

if (GetAsyncKeyState(VK_NUMPAD0)&1) 
{ 
	strideNum +=1;
}

Apparently that code is running MANY times per second. You think you're pressing and releasing the key quickly, but to the computer it was pressed down for a long time (it's doing..~3 billion operations a second..so even 1/10 of a second is a LONG time to the cpu..and it can run your loop code a lot of times -- somewhere near 100 as you say).

1. Detect that the key is down
2. Don't run the "+1 code" until the key is up again (ie. action occurs on key RELEASE, not "any time the key is down", like it is now)

Or use Sleep() as mentioned by user above -- depends how you want the program to act.
The sleep() will still let the code run 5-10 times a second which might be what you want, or do it only on key-release and only perform the +1 each time the key is pressed and then released.

edit: I'd post a link, but I expect you to search..and the logic isn't exactly 'complicated.'

[somewhatpro]

if (GetAsyncKeyState(VK_NUMPAD0)&1) 
{ 
	strideNum +=1;
}

Apparently that code is running MANY times per second. You think you're pressing and releasing the key quickly.

true, and they think by adding the bitwise AND 1 will make it on a "key_pressed one time" state lol

[abuckau907]

...

I basically thought the same thing the first time I read the msdn for it...but after testing I figured it out pretty quickly..

10-30 minutes of testing the function should be enough to learn how to use it..apparently it's too complicated...so why is OP making a wallhack? OP isn't, we (anyone who 'helps') are : |

 

I'm all for helping people with code (check my post history..), but this ish is getting annoying.

"I wanna make wallhack, but can't handle the logic behind key presses"
kind of like
"I wanna make rocket and go to space, but don't know which end of a hammer is for hammering"


it just doesn't make sense..you're doing it wrong.

[wara286]

Apparently that code is running MANY times per second. You think you're pressing and releasing the key quickly, but to the computer it was pressed down for a long time (it's doing..~3 billion operations a second..so even 1/10 of a second is a LONG time to the cpu..and it can run your loop code a lot of times -- somewhere near 100 as you say).

1. Detect that the key is down
2. Don't run the "+1 code" until the key is up again (ie. action occurs on key RELEASE, not "any time the key is down", like it is now)

Or use Sleep() as mentioned by user above -- depends how you want the program to act.
The sleep() will still let the code run 5-10 times a second which might be what you want, or do it only on key-release and only perform the +1 each time the key is pressed and then released.

I added a sleep time of 1 sec but there is still no success... it looks like it still increases not by one... but I figured out that it increases by 1 every time and is displayed in binary... 0, 1, 10, 11, 100, 101, 111 etc. So i think that my problem is at the conversion of int to LPCSTR.

[Harava]

You are using a radix of 2 for itoa, thats why it converts it to binary. I'm guessing you meant to use 10.

_itoa_s

So change:

_itoa_s(strideNum,buffer,20,2);

To:

_itoa_s(strideNum,buffer,20,10);

[abuckau907]

hehe oops..the last argument to the _itoa_s() function.

'radix' , is the base you want to convert to, not the length of the buffer. Should be 10, not 2.
Change to = _itoa(int,buff,new_base);

edit: nvm, thanks @ Harava - I was double-checking the code before telling OP something wrong and you posted in that time.

[Hell_Demon]

This method of stride logging is terribly inefficient and time consuming.

Consider doing the following:
int min_stride = 0;
int max_stride = 10000;
int cur_stride = (max_stride+min_stride)/2;

stridenum >= min_stride and < cur_stride -> color blue
stridenum > cur_stride and <= max_stride -> color red
stridenum == cur_stride -> color green.

if it's too high, set max_s to cur_s, and cur_s to half of max+min.
if it's too low, set min_s to cur_s, and cur_s to half of max+min.
if it's correct: log the stride and reset min/max/cur.

log(n)/log(2) where n is the maximum stride number.
for stride 0 to a 10000 it takes a max of 14 steps.
for stride 0 to 1000000 it takes a max of 21 steps.

[Harava]

This method of stride logging is terribly inefficient and time consuming.

Making a gui for the logger saves a lot of time aswell: