HOW TO HACK (basics)

There is so much wrong with this "tutorial", lol.

You can't consider this a tutorial. A tutorial explains in-depth how stuff works; throwing code at the viewer without explaining it is not a tutorial.
You aren't explaining what a process is, why it's necessary to use the Windows API functions ReadProcessMemory/WriteProcessMemory ( or their kernel representation ) or what alternatives there are. You are not saying that the function OpenProcess wants a process id which you can get in a number of different ways, you are just throwing code at the user saying this is the code to get it to work, use it or die. You aren't giving the viewer room to think about alternatives or coding it themselves as you don't explain it. If you would've said that you just have to get the process id in some way, the user can literally think / google about functions on how to get the process id and use other functions than the ones you provided. You aren't explaining what handles are, why they're used, what they're used for, what different access flags there are etc.. Why do you use PROCESS_ALL_ACCESS in the first place? What is an HWND? What is it used for? You aren't explaining anything.

A tutorial explains the stuff behind it without going in-depth into the code. The code is just to have something to show on the screen. Your "tutorial" is all about the ( bad ) code, not about the stuff behind it.

Apart from this, your title Is "HOW TO HACK", which is not what you show. You are showing ONE way of hacking a game; via the Windows API functions ReadProcessMemory/WriteProcessMemory ( externally ). If you title your thread and video as "HOW TO HACK", at least explain that there are a number of different ways to hack a game and briefly explain them, or else you're telling the newbie that this is the only way to read and write memory.

1. You don't get instantly VAC banned for having cheat engine open.



I don't think I have to explain why this is bad, it has been explained dozens of times already.





You aren't passing by reference. The function wants a pointer to the variable. A pointer stores a memory address. The & is the address-of operator, which will give the address of the variable, aka a pointer to it. You aren't passing by reference.



Why are you using PROCESS_ALL_ACCESS? To expose your process even more towards anti cheats?



Why are you assigning procID to NULL here? You aren't checking the value of procID, you are assigning it to NULL within this if statement. You are lucky that the if statement will evaluate to false due to you assigning procID to NULL. You will ALWAYS execute the statements in the else block, regardless of whether the process id was valid or not. Why are you even trying to check that after you already tried to use OpenProcess? Why are you checking the process id after you used OpenProcess? Why don't you check it before you use OpenProcess? Imagine having a wrong process id; you'll call OpenProcess with a wrong process id and check it afterwards and exit, why don't you check it before you even use OpenProcess to avoid unnecessarily calling a function which exposes your process to an anti-cheat? This is bad design.



Why would you suddenly use PBYTE* now? BYTE** ? Why?





Why would you? You don't seem to understand the purpose of this parameter or what the sizeof keyword returns. sizeof( int ) == sizeof( float ) ( MSVC x86 ). You can put whatever you want into it, you could even make your own class and put it in there, you'll always have the right value as long as you read at least 2 bytes ( 2000 fits into 2 bytes ). You'll always get the right value printed, even if you put float there. The variable declaration matters, not the sizeof.



No, it wouldn't.



GetAsyncKeyState returns 2 values, you aren't bitmasking the result, hence it won't do what you are trying to do.



++i > i++. ++i is faster and better than i++. Unless you have a real reason to use i++, use ++i.

If you don't explain anything and only show code, at least show decent code. Your code is terrible, without trying to be rude. It's bad from a design perspective as well as from the correctness perspective. Your "tutorial" is exactly the reason why people that have no idea shouldn't make tutorials. The PBYTE* thing yet alone shows that you don't seem to have any idea on why you're using it. You just saw it in some tutorial and copied it since. Some guy came up with the really bad idea to use PBYTE*, some guy saw it, used it in his tutorial and so forth. You're spreading bad code & misinformation. Your video looks like you have no idea what you're actually doing but saw some tutorials and try to make your own one now.

Your tutorial is just like fleep's shitty tutorials. He isn't explaining anything while showing bad code.