JS Scripting

Hello,
I am curretly learning JS and did the tutorial from @ZBORNOX and doing the course on codeacademy

Anyways could someone look at this code and kindly tell me what i am doing wrong?
It should be a simple spammer.....

Codelididi

Code:

var ID_TEXT = $.findPacketId("TEXT");
var ID_PLAYER_TEXT = $.findPacketId("PLAYERTEXT");
var number = 0;

function onClientPacket(event) //Here, we handle all the packets we sent to the server
{
    var packet = event.getPacket();
    switch (packet.id()) {
        case ID_PLAYER_TEXT:
        {
            var text = packet.text.toLowerCase();
            if (text.length() >= 4 && text.substring(0, 4) == "/spm")
            {
                TALK(event);
            }
        }
    }
}


function onServerPacket(event) //Here, we handle all the packets we receive from the server
{
    var packet = event.getPacket();
}

function TALK(event)
{
    var talking;
    var packet = event.getPacket();
    switch (packet.id())
    {
        case ID_PLAYER_TEXT:
        {
            var text = packet.text.toLowerCase();
            var text2 = packet.text();
            if (text.length() >= 4 && text.substring(0, 4) == "/spm")
            {
                talking = text2.substring(4, 9999);

                while (1)
                {
                    var playertextPacket = event.createPacket(ID_PLAYERTEXT);
                    rand();
                    playertextPacket.text = talking + bing;
                    wait(1500)
                    event.sendToServer(playertextPacket);
                }
            }
        }
    }
}

function rand()
{
    number++;
    if (number % 2 == 0)
    {
        return ".";
    }

    else
    {
        return "!";
    }
}

function wait(ms)
{
    var d = new Date();
    var d2 = null;

    do { d2 = new Date(); }
    while(d2-d < ms);
}

Thanks!

wait(1500) function doesn't have a semicolon after it

you're doing a while(1) which means you're getting realm relay stuck in an infinite loop

instead, send a message and save the current time, and on every new_tick packet check the current time and if current-last > 1500, send new ptext

I think new_tick sends you the time so you could just use that (if not, use move's time) instead of calculating the system time

Originally Posted by 059

Thanks, trying to do that

The entire TALK function is redundant...

If you are only going to look for a single packet type, you might as well remove the switch case. For substrings, you can just emit the end index and it will go to the end of the string. You call the rand(); function but it returns . or ! to nothing. You probably meant var bing = rand();. Instead of doing the infinite loop, try incorporating and enable boolean that is set to true when the person types /spam kfjlaefa and is set to false when the person types /stop. Then use RealmRelays built in delayed function calls to call some function which will then call itself if still enabled.

This also lets you avoid keeping track of new_tick packets.

Originally Posted by NisuxenZ

Thanks for your help!
I have gone over the code and used a while loop... i dont know if thats something how you ment it

!NEW! Code

Code:

/**
 * Created by Simon on 18.05.2014.
 */

var ID_TEXT = $.findPacketId("TEXT");
var ID_PLAYER_TEXT = $.findPacketId("PLAYERTEXT");
var number = 0;
var boot;

function onClientPacket(event) //Here, we handle all the packets we sent to the server
{
    var packet = event.getPacket();
    switch (packet.id()) {
        case ID_PLAYER_TEXT:
        {
            var text = packet.text.toLowerCase();
            if (text.length() >= 6 && text.substring(0, 6) == "/start")
            {
                boot = true;
                talking = text.substring(7, 9999)
            }

            else if (text.length() >= 6 && text.substring(0, 6) == "/stop")
            {
                boot = false;
            }

            while (boot)
            {
                var playertextPacket = event.createPacket(ID_PLAYERTEXT);
                rand();
                playertextPacket.text = talking + bing;
                event.sendToServer(playertextPacket);
            }
        }
    }
}

var bing = function rand()
{
    number++;
    if (number % 2 == 0)
    {
        return ".";
    }

    else
    {
        return "!";
    }
}

Originally Posted by NisuxenZ

Then use RealmRelays built in delayed function calls to call some function which will then call itself if still enabled.

Also i dont know what you mean with this....

......bumpedy

Originally Posted by The_En|D

Thanks for your help!
I have gone over the code and used a while loop... i dont know if thats something how you ment it

Basically something like this.

code

Code:

/**
 * Created by Simon on 18.05.2014.
 */

var ID_TEXT = $.findPacketId("TEXT");
var ID_PLAYER_TEXT = $.findPacketId("PLAYERTEXT");
var talking = "" ;
var boot = false;
var playertextPacket = event.createPacket(ID_PLAYERTEXT);

function onClientPacket(event) //Here, we handle all the packets we sent to the server
{
    var packet = event.getPacket();
    switch (packet.id()) {
        case ID_PLAYER_TEXT:
        {
            var text = packet.text.toLowerCase();
            if (text.length() >= 6 && text.substring(0, 6) == "/start")
            {
                boot = true;
                talking = text.substring(7);
                spamify();
            }

            else if (text == "/stop")
            {
                boot = false;
            }
        }
    }
}

function spamify()
{
    if(boot)
    {
        var bing = this.rand();
        playertextPacket.text = talking + bing;
        $.sendToServer(playertextPacket);
        $.scheduleEvent(5, "spamify");              // Calls itself in 5 seconds
    }
}

function rand()
{
    number++;
    if (number % 2 == 0)
    {
        return ".";
    }

    else
    {
        return "!";
    }
}

JS Scripting

Post a Reply

Similar Threads

Tags for this Thread