Javascript switch statement on a string

I wanted to change my realm relay script to use a switch instead of a bunch of ifs.

This works, and the doSomething function gets executed:

Code:

if (stringVarName == "Word")
	doSomething(1);
if (stringVarName == "Foo")
	doSomething(2);
if (stringVarName == "Bar")
	doSomething(3);
if (stringVarName == "Qwerty")
	doSomething(4);

This does not work, the doSomething function does not get executed:

Code:

switch (stringVarName) {
case "Word":
	doSomething(1);
	break;
case "Foo":
	doSomething(2);
	break;
case "Bar":
	doSomething(3);
	break;
case "Qwerty":
	doSomething(4);
	break;
default:
	break;
}

Anyone know why? If I do a switch on an int it works fine but not a string.

Also is it faster for the cpu to do one switch, as opposed to ifs?

That switch should be working...
In regards of speed, I do remember Java had issues with the switch statement being very slow with strings in specific but that's fixed, not sure about javascript.

Assuming it plays well with strings, switch statements can sometimes be faster with a large amount of cases vs if elses, but its nothing noticeable at all in a case of scripting for RR lol...

Originally Posted by krazyshank

I talked to my friend about it and he told me that switch statements never work on strings, only ints and chars, so that may be the problem.

As for the speed differences, thanks. Wasn't too sure but it seems like faster would be preferable, more so if you're multiboxing.

Originally Posted by 059

he told me that switch statements never work on strings

That's not entirely true, you can use strings with switch but it needs some more code:

Code:

function test(str) {
    switch (true) {
      case /word/.test(str):
	doSomething(1);
        break;
      case /foo/.test(str):
	doSomething(2);
        break;
      case /bar/.test(str):
	doSomething(3);
        break;
      case /qwerty/.test(str):
	doSomething(4);
        break;
    }
}

Javascript switch statement on a string

Post a Reply

Similar Threads

Tags for this Thread