Okay, so recently i got assigned to a project with the "top" developer at a company, but it turns out this guy has some of the messiest code i have EVER seen, and he is EXTREMELY stuck up. He thinks he's the best programmer in the entire world.
He doesn't know how to use classes or methods, he basically writes most of his code in main, even if that same block of code is going to be used over and over again.
Edit: Ugh he just told me not to use a try catch on something because the chances it will throw an error are small... Wtf.
How do i deal with this? D: Should i just refactor all his code?
It should be awful i rlly dont want be on your skin now,my Mom would say that telling the true is the best thing to do but i never believed.What you can do? Restruct is a option,not a easy one but is a option think about
Sorry for my english.
At the moment, don't refactor his shit code. It will take time, and your efforts won't be noticed by all the non-developers in the company anyway. I had the same problem a few weeks ago where the coder before me was absolute crap. Public code that was all uncommented despite the complexity of the project, and he didn't seem to have the concept of RE-USABILITY at all.
IMO, make your own code that you add neat and well documented so that you don't contribute to the shitheap, then just start proving yourself to be a more adept developer than your colleague. If your company is any good they'll recognize that you're getting stuff done faster, and more efficiently than your colleague and probably stand you to replace him, or give you free rein over the projects. Then it's time to refactor.
Until you actually control the projects yourself, you'll be facing constant refactoring as the guy continues to code like crap. If he is as stuck up as you make him sound, he's not going to take criticism well and refactoring someone's code is pretty insulting, wait until someone higher than him in the company knocks him off his high horse or you'll just make an unnecessary enemy.
Another issue with refactoring without his consent is that you are now working in a team, you can't just redo all his code behind his back and then expect to function as a team, coding conventions should always be laid out at the start of a project so things like indentations, styles, naming conventions, documentation and the like are constant throughout all files.
Kill him, it will make sure he never codes poorly again
I remember that we had to review others code in the company like every week, so the "newbs" could learn something from someone who can actually code decently, and those who didn't code decently, they had re write some of the code.
It was like 2 hours per week. It was a good way of Refactoring old code, and learn something in the end.
(this included error detection, messy code, slow code, etc... we had a list)
I'm with Jason, in the end someone who is actually superior will notice your job.
Originally Posted by cfsharp
Okay, so recently i got assigned to a project with the "top" developer at a company, but it turns out this guy has some of the messiest code i have EVER seen, and he is EXTREMELY stuck up. He thinks he's the best programmer in the entire world.
He doesn't know how to use classes or methods, he basically writes most of his code in main, even if that same block of code is going to be used over and over again.
Edit: Ugh he just told me not to use a try catch on something because the chances it will throw an error are small... Wtf.
How do i deal with this? D: Should i just refactor all his code?
arrgh what a crappy coder......i dont think he deserves to be called a coder.....
Ask him what the hell his logic is behind putting it all in main
about the try catch... =
What coding language?
ugh, you should show him off. I have met too many cocky people in this world.
Originally Posted by 0xC0D3
ugh, you should show him off. I have met too many cocky people in this world.
this guy is him D :
I wish, then I would have a job, but I don't and my code is prob more horrible than anything you've seen.
I was just joking =o
I know...=P
These cocky people get jobs and they think they're good at it. It sucks. >_<
Lol... He learned how to use async sockets yesterday, with my help, and now he's acting like he is superior to everyone with them... But anyways what i'll do is, i'll just write and document all my code, using all the techniques that i was taught/just find common sense, and let him write his code, and in the end hopefully it all works and i don't ever have to work with him again. D:
P.S. Lolol Jason he doesn't even know what a coding convention is... I talked to him about setting up a convention so that i could find easier where he starts and ends his methods, but he was like"... wat?"
Out of curiosity, is this actually a company of some substance? Most places generally assess developers before making them their "top developer"
Originally Posted by Jason
Out of curiosity, is this actually a company of some substance? Most places generally assess developers before making them their "top developer"
It's a company, that's trying to get started, and the owner is a good guy, and an amazing web developer, but his C# programmer sucks balls... Here's something that i quoted from skype...
See... The guy is crazy.
Oh yeah, all the other programmers are solid programmers i seen some of their code it's pretty good, but this guy just doesn't have a clue what's going on
& I forgot to mention i'm just volunteering to help out a bit.
Even starting out companies should screen their employees, otherwise you start behind the 8 ball with substandard coders.