Extra Credit IQOD #2A

Ok since we're on a roll i'm posting an open ended question here:

Consider the following:

Code:

void MyClass::DoSomething()
{
   //Some code here
   delete this;
}

What are your thoughts on this function? why?

Originally Posted by B1ackAnge1

Ok since we're on a roll i'm posting an open ended question here:

Consider the following:

Code:

void MyClass::DoSomething()
{
   //Some code here
   delete this;
}

What are your thoughts on this function? why?

slightly less confused:
I forgot 'this' means it is pointing to itself(the memory where the class is allocated after using new)
therefor this function would be a cleanup function amiright?

MyClass *testing = new MyClass; //allocate new memory for our class to put its shizzle in
//perform some random crap untill we no longer need it
//done performing random crap so lets clean up
testing->DoSomething(); //delete the allocated memory

edit:
ok wtf...
your post as it was before is in my quote, and now it says HI ARUN2 and HI ARUN1 o__O but it does not say 'last edited by' or anything

this is scary :P

edit2:
HI ARUN1 dissappeared(it was at the end of the post) and the other one is still there

huh? I did NOT put that in...

Originally Posted by B1ackAnge1

huh? I did NOT put that in...

weird, i found some more posts containing HI ARUN2 but 1 is rare ;o
btw was my answer correct?

hmm you sorta follow what's going on but is that good or bad?
say you had a 3rd party DLL with that method in it that you have to call . Would you know it did that? Should it do that? why/why not?

Let me show something that would be a typical scenario..

Code:

MyClass* pClass = new MyClass;
...Do Stuff on pClass
pClass->DoSomething();
...Do Stuff on pClass
delete pClass;

What do you think about it now? Do you see any potential problems?

Originally Posted by B1ackAnge1

hmm you sorta follow what's going on but is that good or bad?
say you had a 3rd party DLL with that method in it that you have to call . Would you know it did that? Should it do that? why/why not?

/me changed status into confused again.

Updated my post above yours with a sample that should more clearly show the issue

dosomething deletes the allocated memory therefor making the pointer point to NULL, after that you delete it again which will result into a problem im afraid.

edit: doing stuff after dosomething will also result in problems since its no longer there.

Correct - other valid answers would have been:
Find the guy who wrote that and beat'm

So this is something you NEVER want to do and is VERY BAD practice

Originally Posted by B1ackAnge1

Correct - other valid answers would have been:
Find the guy who wrote that and beat'm

So this is something you NEVER want to do and is VERY BAD practice

woot

i win another cookie :d yay

Shoudl start keeping track of scores

Originally Posted by B1ackAnge1

Shoudl start keeping track of scores

what does the winner(me ofcourse :P) get? ^^
Lifetime VIP on cookies i hope

or a job as imontheothersideoftheworldcoder

It looks like a Deconstructor because it deletes the pointer to the object that it was called on. So in essence it deletes the object? I'm guessing you can't have two deconstructors in an object. What would happen?

Yeh I'm seeing the little Hi Arun thing too o_O its weird ...

Originally Posted by why06

make your text white... NOW!

Lets see:


By the way, i already read the question about why it's bad you posted to HD, and my answer is this is bad because the unsuspecting user might try to delete his pointer to the class that he dynamically allocated after he has already used that method. Which would be bad because you should never try to delete the same allocated memory twice.

Btw, BlackAngel, These supremely rock. Not only is this something for the C++ board community to do, but it is also telling us things that are expected of us to know, if we ever want a C++ programming job. Even if i get it completely wrong, that is good because i end up learning even more.

Extra Credit IQOD #2A

Post a Reply

Similar Threads

Tags for this Thread